Skip to content

CFE-3882: Added strtotime policy function - #6237

Merged
larsewi merged 1 commit into
cfengine:masterfrom
victormlg:strtotime
Aug 25, 2026
Merged

CFE-3882: Added strtotime policy function#6237
larsewi merged 1 commit into
cfengine:masterfrom
victormlg:strtotime

Conversation

@victormlg

@victormlg victormlg commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

larsewi
larsewi requested changes Jul 16, 2026
View reviewed changes

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some acceptance tests :)

olehermanse
olehermanse previously requested changes Jul 17, 2026
View reviewed changes

@olehermanse olehermanse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as @larsewi said not much to review here, please add acceptance test. Most code review is in libntech.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

Marking this PR as stale due to inactivity; it will be closed in 7 days.

@github-actions github-actions Bot added the stale Pull requests with no recent activity label Aug 16, 2026
@github-actions github-actions Bot removed the stale Pull requests with no recent activity label Aug 17, 2026
@victormlg
victormlg force-pushed the strtotime branch 3 times, most recently from f264368 to 189600a Compare August 18, 2026 13:28
github-advanced-security[bot]
github-advanced-security Bot found potential problems Aug 18, 2026
View reviewed changes
Comment thread libpromises/evalfunction.c Fixed
@victormlg
victormlg force-pushed the strtotime branch 2 times, most recently from 38e6fef to c76539d Compare August 18, 2026 13:53
larsewi
larsewi requested changes Aug 19, 2026
View reviewed changes

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new functions in pipes.h probably deserve their own commit.

Comment thread libpromises/evalfunction.c Outdated
Comment thread libpromises/evalfunction.c Outdated
Comment thread libpromises/evalfunction.c Outdated
Comment thread libpromises/evalfunction.c Outdated
Comment thread libpromises/evalfunction.c Outdated
Comment thread libpromises/evalfunction.c Outdated
Comment thread libpromises/evalfunction.c Outdated
@victormlg
victormlg force-pushed the strtotime branch 2 times, most recently from 13e8c8b to 0486ef1 Compare August 19, 2026 14:57
@victormlg
victormlg requested a review from larsewi August 19, 2026 16:20
@larsewi

larsewi commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@cf-bottom Jenkins please :)

@cf-bottom

cf-bottom commented Aug 19, 2026

Copy link
Copy Markdown

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14538/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14538/

@victormlg

victormlg commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

@cf-bottom Jenkins please :)

@cf-bottom

cf-bottom commented Aug 20, 2026

Copy link
Copy Markdown

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14548/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14548/

@victormlg
victormlg force-pushed the strtotime branch 3 times, most recently from d2df10a to 60f60e7 Compare August 24, 2026 09:38
@victormlg

victormlg commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins, please :)

@cf-bottom

cf-bottom commented Aug 24, 2026

Copy link
Copy Markdown

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14569/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14569/

@victormlg
Added strtotime policy function
5eaf186 
Ticket: CFE-3882
Changeglog: Title
Signed-off-by: Victor Moene <victor.moene@northern.tech>
@victormlg

victormlg commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Build Status

@victormlg

victormlg commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

With buildscript review:

Build Status

@larsewi
larsewi merged commit 94de31e into cfengine:master Aug 25, 2026
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsewi larsewi larsewi approved these changes
@SimonThalvorsen SimonThalvorsen Awaiting requested review from SimonThalvorsen
@olehermanse olehermanse Awaiting requested review from olehermanse
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@victormlg @larsewi @cf-bottom @olehermanse @github-advanced-security