Repository navigation
Conversation
Reject null scalar values and keep loading valid entries. Changelog: Title Ticket: none Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
|
Thanks for submitting a pull request! Maybe @craigcomstock can review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A null variable value in
host_specific.jsoncrashedcf-agentandcf-promises. Reject it and keep loading valid entries.Behavior chosen: a scalar null is logged as an error and skipped, the rest of the file still loads, and nulls inside lists and data keep their current meaning. If you would prefer it to be fatal, an empty string, or to undefine the variable, I can change it.
Debug test: fails before, passes after; 12/12 CMDB tests pass. AI-assisted.
Details: issue, tests and reviews.