Skip to content

DMI inventory now skips sysfs files that cf-agent cannot read (3.24.x) - #3246

Merged
larsewi merged 1 commit into
cfengine:3.24.xfrom
larsewi:dmi-sysfs-isreadable-3.24.x
Nov 16, 2026
Merged

larsewi merged 1 commit into
cfengine:3.24.xfrom
larsewi:dmi-sysfs-isreadable-3.24.x

Conversation

@larsewi

@larsewi larsewi commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Some files in `/sys/devices/virtual/dmi/id/`, such as `product_serial`,
are only readable by root. `fileexists()` lets `readfile()` run anyway,
causing unprivileged agents to log a permission denied error.

Instead we use `isreadable()` to guard the read. However, `isreadable()`
is only available in CFEngine >= 3.22.

Changelog: Title
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
(cherry picked from commit 640062b)
@larsewi

larsewi commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@cf-bottom Jenkins please :)

@cfengine cfengine deleted a comment from cf-bottom Nov 13, 2026
@cf-bottom

Copy link
Copy Markdown

@larsewi
larsewi marked this pull request as ready for review November 13, 2026 12:54
@larsewi
larsewi requested a review from nickanderson November 13, 2026 12:54
@larsewi
larsewi merged commit 7b44b65 into cfengine:3.24.x Nov 16, 2026
40 checks passed
@larsewi
larsewi deleted the dmi-sysfs-isreadable-3.24.x branch November 16, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants