修复 Runner 工具输出非法 UTF-8 导致 terminal 丢失 - #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Runner 工具和 PTY 输出本质上是任意字节。此前
progressStreamer会直接把原始[]byte转成 protobufstring,工具最终结果也没有统一校验。遇到0xff等非法 UTF-8 时,aop.Wrap编码失败,消息会被丢弃;若丢失的是 terminal ToolResult,上游调用会一直等待到超时。修复
strings.ToValidUTF8。ExecuteToolRequest返回 terminal event 前,递归清洗 CallId、Name、text、reasoning、refusal 以及嵌套 ToolResult。验证
go test ./pkg/runner ./pkg/nodego test -race ./pkg/runner ./pkg/node