Repository navigation
Fix width calculation for multiline vertical legend labels - #12339
Open
Aurantium-47 wants to merge 1 commit into
Open
Aurantium-47 wants to merge 1 commit into
Aurantium-47 wants to merge 1 commit into
Conversation
Assisted-by: OpenAI GPT-6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A multiline label in a left or right legend can be clipped when its widest line has fewer characters than another line. For example,
['WWW', 'iiiiiiii']currently reserves less width than'WWW'alone in a proportional font.Measure each line and use the largest pixel width for the legend layout and hitbox. The regression tests cover both legend positions and compare against the same chart updated to its widest single line, without hard-coded pixel sizes.
Validation on Windows with Node 24:
Implemented and validated using OpenAI Codex.