Repository navigation
Fix hover positioning with CSS zoom - #12343
Open
SasmitNarnaware wants to merge 1 commit into
Open
SasmitNarnaware wants to merge 1 commit into
SasmitNarnaware wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect hover and tooltip positioning when a chart's canvas or ancestor is scaled using the CSS zoom property.
Changes
Normalize pointer coordinates to account for CSS zoom in getCanvasPosition.
Add three regression tests covering CSS zoom-related interaction behavior.
Testing
Regression tests: verified to fail before the fix and pass after it.
Helpers test suite: 443 successful tests across Chrome and Firefox, with one Firefox test skipped because the environment does not expose the Touch constructor.
JavaScript lint: zero errors; warnings match the existing baseline.
Full test suite: some pre-existing fixture and Firefox environment-related failures remain; see the investigation report for details.