Skip to content

fix(cli): make executable presence detection actually probe PATH [RED-887] [ship] #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorccu merged 1 commit into from
Aug 31, 2026
+7 −8
Merged

fix(cli): make executable presence detection actually probe PATH [RED-887] [ship] #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/cli/src/services/check-parser/package-files/__tests__/package-manager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,4 +632,10 @@ describe('PathLookup', () => {
expect(await lookup.lookupPath('node')).toBeDefined()
expect(await lookup.lookupPath('checkly-no-such-executable-xyz')).toBeUndefined()
})

it('detects the presence of an executable on PATH and throws for one that is missing', async () => {
const lookup = new PathLookup()
await expect(lookup.detectPresence('node')).resolves.toBeUndefined()
await expect(lookup.detectPresence('checkly-no-such-executable-xyz')).rejects.toThrow()
})
})
9 changes: 1 addition & 8 deletions packages/cli/src/services/check-parser/package-files/package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,15 +819,8 @@ export class PathLookup {
}
}

// FIXME(RED-887): the missing `await` below means `foundPath` is a
// Promise — always defined — so this never throws and executable
// detection always "succeeds". Fixing it changes package-manager
// detection outcomes on machines that lack the executable, so it is
// tracked as a follow-up rather than fixed in passing; use lookupPath()
// for a working check.
// eslint-disable-next-line require-await
async detectPresence (executable: string): Promise<void> {
const foundPath = this.lookupPath(executable)
const foundPath = await this.lookupPath(executable)
if (foundPath === undefined) {
throw new NotDetectedError()
}
Expand Down
Loading