Skip to content

Replace the leftover bindings/go references, and extend the Go path guard #1040

Description

@auxesis

The Go module rename in #1001 changed every full module path, but some prose still names the old bindings/go folder. The guard test scripts/__tests__/go-module-path.test.mjs checks only the full module path, so it does not catch these. coderdan found them in review of #1001.

Instructions that no longer work

  • languages/golang/stackencrypt/example/README.md:19
  • languages/golang/stackencrypt/example/explicit/README.md:27 and :31, which say cd bindings/go

Comments that name the old folder

  • languages/golang/stackencrypt/example/main.go:7
  • packages/stack-encrypt/CONTEXT.md:6
  • packages/stack-guest-abi/Cargo.toml:12 and packages/stack-guest-abi/tasks.toml:2
  • packages/stack-guest-abi/src/lib.rs and src/buffers.rs
  • languages/golang/stackauth/guest/src/lib.rs:52
  • both guests' Cargo.toml
  • ADR 0005

Fix

Replace each with languages/golang. Then extend the guard with a second search for bindings/go, with an allowlist for the github.com/cipherstash/vitaminc/bindings/go/... imports, so the old folder name cannot come back.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    SDKdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions