Conversation
The comment above the mise step in the release job still quoted the root `version` script as `changeset version && node scripts/sync-lockstep-versions.mjs`. Since #1028 it also runs scripts/sync-skill-pins.mjs between the two. Quote it as it is. Refs: CIP-4285 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PaY5xYydZUWhv8Nex9Sw8a
|
The main-guard comment in scripts/sync-lockstep-versions.mjs and the header of scripts/__tests__/script-main-guards.test.mjs both quoted the root `version` script as `changeset version && node scripts/sync-lockstep-versions.mjs`. Since #1028 it also runs scripts/sync-skill-pins.mjs between the two. Quote it as it is. Both comments keep their point: the `&&` chain reads a silent exit 0 as a completed bump. Refs: CIP-4285 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PaY5xYydZUWhv8Nex9Sw8a
freshtonic
left a comment
There was a problem hiding this comment.
Approved. The three comments now quote the root version script as it is on this head: changeset version && node scripts/sync-skill-pins.mjs && node scripts/sync-lockstep-versions.mjs (package.json:38). Each comment keeps its original argument. The added words "that last script" in release.yml make it clear that sync-lockstep-versions.mjs calls mise, not sync-skill-pins.mjs.
Checks I did:
- No test reads the text of these comments.
workflow-mise-setup.test.mjsalready writes the chain aschangeset version && … && node scripts/sync-lockstep-versions.mjs, so it was correct before and after this change. - No other live comment quotes the old two-step script. The only old quotes that remain are in
docs/plans/2026-08-13-eql-monorepo-absorption.md. That is a historical plan, so it is correct to keep it as it is. - No changeset is necessary. The change touches only comments in a workflow, a script, and a test, and none of these ship in a package.
This pull request corrects three comments that quote the root
versionscript. It changes no behaviour.The comments quoted the old version script
Three comments quoted the root
versionscript aschangeset version && node scripts/sync-lockstep-versions.mjs. Pull request #1028 added a step between the two, so the script is nowchangeset version && node scripts/sync-skill-pins.mjs && node scripts/sync-lockstep-versions.mjs. Each comment now quotes it as it is. This is follow-up work for Linear issue CIP-4285..github/workflows/release.yml: the comment above the mise step in thereleasejob. It now also says that the last script is the one that calls mise.scripts/sync-lockstep-versions.mjs: the comment on the main guard.scripts/__tests__/script-main-guards.test.mjs: the header of the test.The last two comments keep their point. The
&&chain reads a script that exits 0 without doing anything as a completed version bump.Checks
actionlint1.7.7 withshellcheck0.11.0 onrelease.yml: no findings.pnpm test:scripts: 67 files pass.pnpm run code:check: no errors.Linked issues
Part of #1044.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PaY5xYydZUWhv8Nex9Sw8a