fix(scripts): protect latency CSV from cache path collisions - #368
Open
skyc1e wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing the same file to
--csvand--dbwith--rebuild-dbdeletes the source before reading it. With a valid header-only CSV, the command even exits successfully after replacing the input with a SQLite database.Reject matching file identities before opening the cache or rebuilding it, including relative paths, symlinks, and hardlinks. The CLI now reports
--csv and --db must refer to different files, exits with status 1, and leaves the source unchanged. Normal reporting with a separate cache is preserved.Validation:
cd scripts && python -m unittest test_tx_latency_report -q: 54 tests, successful with one symlink subtest skipped because Windows requires additional privileges. The hardlink case passes.git diff --checkpasses. Tested with Python 3.12.14; Rust/node integration tests were not run for this Python-only change.