Skip to content

Update ble-file-transfer-js to 1.2.0 - #558

Merged
makermelissa merged 1 commit into
circuitpython:mainfrom
dhalbert:ble-file-transfer-1.2.0
Aug 24, 2026
Merged

Update ble-file-transfer-js to 1.2.0#558
makermelissa merged 1 commit into
circuitpython:mainfrom
dhalbert:ble-file-transfer-1.2.0

Conversation

@dhalbert

Copy link
Copy Markdown
Contributor

Claude found the underlying bugs and wrote the library fixes.

Brings in ble-file-transfer-js 1.2.0 (adafruit/ble-file-transfer-js#15):

  • Reads the transfer characteristic before subscribing, so pairing is triggered reliably. This makes espressif boards pair at all on firmware before adafruit/circuitpython#11236, and avoids doubled responses on Windows.
  • Stops notifications before starting them, so reconnecting to a bonded board works. With 1.1.0, a Disconnect followed by a Connect hangs at "Current Device Info".
  • Doubled or malformed responses are reported as errors instead of hanging a transfer forever.

Testing

Tested this library version on a Feather nRF52840 and a Metro ESP32-S3 from Chrome on Linux and on Windows 11, including first pairing and bonded reconnect on both.

🤖 Generated with Claude Code

Brings in the pairing and reconnect fixes: read before subscribing so
pairing is triggered reliably, stop-then-start notifications so bonded
reconnects resume, and doubled or malformed responses reported as errors
instead of hanging.
@dhalbert
dhalbert requested a review from makermelissa August 24, 2026 20:14

@makermelissa makermelissa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makermelissa
makermelissa merged commit 99c7402 into circuitpython:main Aug 24, 2026
1 check passed
@dhalbert
dhalbert deleted the ble-file-transfer-1.2.0 branch August 24, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants