Repository navigation
feat(mosaic): split control and container borders and use washes for states - #10496
Draft
prestonwebdev wants to merge 1 commit into
Draft
prestonwebdev wants to merge 1 commit into
prestonwebdev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 39fa9d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
3 of 9 tasks
prestonwebdev
force-pushed
the
prestonwebdev/mosaic-color-adoption
branch
from
October 28, 2026 23:16
5636b0b to
3ff6a6f
Compare
…states Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
prestonwebdev
force-pushed
the
prestonwebdev/mosaic-color-adoption
branch
from
October 29, 2026 22:24
3ff6a6f to
39fa9d9
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
| const neutralHoverWash = `inset 0 0 0 100vmax ${colorVars['--cl-color-neutral-alpha-100']}`; | ||
| const neutralPressedWash = `inset 0 0 0 100vmax ${colorVars['--cl-color-neutral-alpha-200']}`; | ||
| const negativeHoverWash = `inset 0 0 0 100vmax ${colorVars['--cl-color-negative-alpha-200']}`; | ||
| const negativePressedWash = `inset 0 0 0 100vmax ${colorVars['--cl-color-negative-alpha-300']}`; |
Member
There was a problem hiding this comment.
hmm, not sure we want to be doing this for a hover effect. any strong reason not to use color mix to achieve this hover state?
|
|
||
| import { colorVars, radiusVars, space } from '../../tokens.stylex'; | ||
|
|
||
| const filledWash = `light-dark(color-mix(in oklab, ${colorVars['--cl-color-neutral']} 3.5%, transparent), color-mix(in oklab, ${colorVars['--cl-color-neutral']} 4.5%, transparent))`; |
Member
There was a problem hiding this comment.
was hopeful to reduce spreading different opacity usages like this through the implementations. was pat of the goal of the alphas. non-blocking if we think we need this custom here though.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves Mosaic components onto the new border and tint tokens.
--cl-color-border. Containers and dividers (cards, sections, tables, menus, the profile nav) use--cl-color-border-subtle.-subtleand-bordertokens, and the neutral badge and banner use--cl-color-neutral-subtle.Stacked on #10493.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code