Skip to content

docs(expo): say the UserButton takes custom pages too in the Expo verify skill - #10524

Merged
mikepitre merged 1 commit into
mainfrom
mike/stoic-feynman-d8aeqw
Oct 29, 2026
Merged

mikepitre merged 1 commit into
mainfrom
mike/stoic-feynman-d8aeqw

Conversation

@mikepitre

Copy link
Copy Markdown
Contributor

Description

This is the periodic maintenance pass of the verify-clerk-expo skill. A gotcha on user-button-and-profile.md said that custom pages are something only an inline UserProfileView has. UserButton also takes them, through userProfileProps.customPages and customDestinations (packages/expo-native-components/src/UserButton.tsx). The test app passes custom pages only to its embedded profile. The gotcha now says that, and it says no spec covers custom pages on the UserButton.

A source read of the other Expo feature pages found no drift. Run r20261029-121806-ef16 ran every committed spec on a remote iPhone 17 Pro on macos-26 at c427276, this branch's base, and passed 17 of 17. The change is docs-only, so the run was on iOS alone.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Generated by Claude Code

…ify skill

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WtSUsqVY7Ef1gw7c8nAvsu
@vercel

vercel Bot commented Oct 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 29, 2026 12:33pm UTC
swingset Ready Ready Preview Oct 29, 2026 12:33pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4c0450f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 8098bb9 and 4c0450f.

Files selected for processing: 2
  • .changeset/verify-expo-custom-pages.md
  • .claude/skills/verify-clerk-expo/features/user-button-and-profile.md
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The profile-testing note now says to open the profile through the UserButton to test that path. It distinguishes this from inline-only behavior covered by embeddedProfile and notes that no spec covers custom pages passed through userProfileProps.customPages. The changeset file now contains two YAML front-matter delimiters with no content between them.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: wobsoriano

Merge Risk: Minimal · up to 4c045

The documentation update is ready to merge with no identified actionable risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main documentation change: documenting that Expo UserButton supports custom pages.
Description check Passed The description directly explains the documentation update, the UserButton API paths, test-app behavior, and validation results.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@mikepitre
mikepitre requested a review from a team October 29, 2026 12:34
@mikepitre
mikepitre enabled auto-merge (squash) October 29, 2026 12:34
@pkg-pr-new

pkg-pr-new Bot commented Oct 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10524

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10524

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10524

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10524

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10524

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10524

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10524

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10524

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10524

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10524

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10524

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10524

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10524

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10524

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10524

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10524

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10524

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10524

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10524

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10524

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10524

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10524

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10524

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10524

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10524

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10524

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10524

commit: 4c0450f

@mikepitre
mikepitre merged commit ef37b8f into main Oct 29, 2026
56 checks passed
@mikepitre
mikepitre deleted the mike/stoic-feynman-d8aeqw branch October 29, 2026 12:42

This branch was successfully deployed

2 active deployments
Preview – swingset — 4c0450f2 Deployed Oct 29, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 4c0450f2 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants