Skip to content

test(mosaic): wait for the added address's poll in the email link reverification test - #10537

Open
alexcarpenter wants to merge 1 commit into
mainfrom
carp/mosaic-email-link-flake-test
Open

alexcarpenter wants to merge 1 commit into
mainfrom
carp/mosaic-email-link-flake-test

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

Fixes the flaky test "continues to the emailed link after confirming the session".

Email link pollers from earlier tests in the file can keep polling after their dialog is dismissed, and their GET /v1/me/email_addresses/idn_pending requests reach this test's catch-all hold. The test then saw two held requests, or verified the address before its link was sent. The test now waits for exactly one poll for the address it added and ignores the rest.

Checklist

  • pnpm test runs as expected. (targeted: Mosaic user-profile-email-section)
  • pnpm build runs as expected. (pnpm turbo build --filter=@clerk/mosaic...)
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: test flake

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 29, 2026 11:57pm UTC
swingset Ready Ready Preview Oct 29, 2026 11:57pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6437bdb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Walkthrough

The emailed-link verification test now waits for a polling request to the endpoint for the newly added email address. The pull request also adds a changeset file with empty frontmatter.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

  • clerk/javascript#10453: Fixes a stale session write in the fake FAPI session-touch handler that can affect the same emailed-link test.
  • clerk/javascript#10535: Stops email-link and enterprise SSO polling after cancellation, addressing leaked polling associated with the same test.

Suggested reviewers: austincalvelage, ephem

Merge Risk: Minimal · up to 6437b

No actionable merge-blocking risk was identified in the test update or changeset.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: updating the Mosaic test to wait for the added email address's poll.
Description check Passed The description directly explains the test flake, its cause, and the requested polling behavior. It is related to the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10537

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10537

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10537

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10537

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10537

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10537

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10537

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10537

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10537

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10537

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10537

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10537

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10537

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10537

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10537

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10537

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10537

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10537

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10537

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10537

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10537

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10537

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10537

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10537

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10537

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10537

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10537

commit: 6437bdb

This branch was successfully deployed

2 active deployments
Preview – swingset — 6437bdb4 Deployed Oct 29, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 6437bdb4 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant