Skip to content

chore: fix dev / turbo.json#9004

Open
thiskevinwang wants to merge 1 commit into
mainfrom
kevin/fix-turbo
Open

chore: fix dev / turbo.json#9004
thiskevinwang wants to merge 1 commit into
mainfrom
kevin/fix-turbo

Conversation

@thiskevinwang

@thiskevinwang thiskevinwang commented Jun 25, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Added dedicated development tasks for key packages to streamline package-level dev workflows with the correct build prerequisites.
  • Bug Fixes
    • Prevented build output from being cleared during watch mode, avoiding empty-directory issues during development.
    • Improved publish/watch build behavior so rebuilds occur smoothly without altering the primary build outputs.

@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a01dd20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jul 8, 2026 10:29pm
swingset Ready Ready Preview, Comment Jul 8, 2026 10:29pm

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Jun 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9004

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9004

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9004

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9004

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9004

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9004

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9004

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9004

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9004

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9004

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9004

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9004

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9004

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9004

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9004

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9004

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9004

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9004

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9004

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9004

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9004

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9004

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9004

commit: a01dd20

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-08T22:31:50.296Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on a01dd20.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87f88fc15f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread turbo.json
"dev": {
"cache": false
},
"@clerk/clerk-js#dev": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required changeset

The root /workspace/javascript/AGENTS.md requires every PR to include a changeset, using pnpm changeset:empty for tooling/repo-only changes. This commit changes the dev/build pipeline but adds no .changeset entry, so the release metadata requirement for this PR is unmet; add an empty changeset if there is no user-facing package impact.

Useful? React with 👍 / 👎.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 87bf1625-8d13-4f30-afc3-85ab8dcae42f

📥 Commits

Reviewing files that changed from the base of the PR and between c69e68e and a01dd20.

📒 Files selected for processing (3)
  • packages/localizations/tsdown.config.mts
  • packages/shared/tsdown.config.mts
  • turbo.json
💤 Files with no reviewable changes (1)
  • turbo.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/shared/tsdown.config.mts
  • packages/localizations/tsdown.config.mts

📝 Walkthrough

Walkthrough

This change makes the localizations and shared tsdown configs watch-aware so rebuilds keep dist output, and adds turbo dev tasks for four packages with cache disabled and build-task dependencies.

Changes

Build config and turbo task updates

Layer / File(s) Summary
Watch-aware clean in tsdown configs
packages/localizations/tsdown.config.mts, packages/shared/tsdown.config.mts
clean now uses !watch instead of always true; the localizations config also destructures { env, watch } and derives shouldPublish from env.publish.
Turbo dev task wiring
turbo.json
Adds @clerk/clerk-js#dev, @clerk/ui#dev, @clerk/shared#dev, and @clerk/localizations#dev with cache: false and dependsOn links to build tasks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A bunny watched the builds go by,
Kept dist intact beneath the sky,
With dev tasks linked and ready near,
The turbo path is crisp and clear,
Hop hop — rebuilds now shed no tear 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the main change, calling out dev and turbo.json updates, though it omits the watch-aware tsdown config changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant