durability: Make local History truly read-only#5497
Merged
Conversation
`Commitlog::open` may perform repairs, which can be catastrophic if access is not externally guaranteed to be mutually exclusive. Instead of allowing to view `Commitlog` as a `History`, implement a `LocalHistory` that is guaranteed to be read-only.
Shubham8287
approved these changes
Jul 8, 2026
bfops
pushed a commit
that referenced
this pull request
Jul 15, 2026
…tory` truly read-only (#5497) `Commitlog::open` may perform repairs, which can be catastrophic if access is not externally guaranteed to be mutually exclusive. Instead of allowing to view `Commitlog` as a `History`, implement a `LocalHistory` that is guaranteed to be read-only. 1.5 Should pass existing tests. --------- Co-authored-by: Phoebe Goldman <phoebe@goldman-tribe.org> Co-authored-by: Shubham Mishra <shivam828787@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commitlog::openmay perform repairs, which can be catastrophic if access is not externally guaranteed to be mutually exclusive.Instead of allowing to view
Commitlogas aHistory, implement aLocalHistorythat is guaranteed to be read-only.Expected complexity level and risk
1.5
Testing
Should pass existing tests.