Http handler disconnect fix.#5498
Merged
Merged
Conversation
kim
approved these changes
Jul 8, 2026
gefjon
reviewed
Jul 8, 2026
gefjon
left a comment
gefjon
left a comment
Contributor
There was a problem hiding this comment.
This seems complicated and weird. Why aren't we just tokio::spawning the whole body of the handler function, or rather, the block which contains the connect, call, and disconnect parts?
Contributor
Author
I think that would have worked too. It’s just that the current approach avoids doing the heavy lifting, like the actual reducer or SQL work, if the client disconnects before it starts. Another reason is convenience: otherwise, everything that goes into |
gefjon
reviewed
Jul 8, 2026
Shubham8287
force-pushed
the
shub/fix-http-disconnection
branch
from
747dafb to
64ffd8d
Compare
Shubham8287
force-pushed
the
shub/fix-http-disconnection
branch
from
64ffd8d to
297c01d
Compare
Closed
gefjon
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
fix for - #5496.
API and ABI breaking changes
NA
Expected complexity level and risk
1.5
Testing
Smoketest added in base branch.