Skip to content

Add real_getrandom for macos#5501

Merged
jsdt merged 3 commits into
masterfrom
jsdt/macos-random
Jul 9, 2026
Merged

Add real_getrandom for macos#5501
jsdt merged 3 commits into
masterfrom
jsdt/macos-random

Conversation

@jsdt

@jsdt jsdt commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

This adds a mac version of real_getrandom to fix compilation errors.

Expected complexity level and risk

  1. This is test only.

Testing

This fixes compilation errors locally for me.

@jsdt jsdt requested a review from Shubham8287 July 9, 2026 01:26

@Shubham8287 Shubham8287 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this troubled you unless you tried to run dst code in your mac?

Wondering, if this was causing problem with normal linting or compilation.

@jsdt

jsdt commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

This was causing errors when linting/fmting.

@jsdt jsdt enabled auto-merge July 9, 2026 14:57
@Shubham8287

Copy link
Copy Markdown
Contributor

This was causing errors when linting/fmting.

It should not because all this code is gated by a feature. Was it in private?

@jsdt

jsdt commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

This was causing errors when linting/fmting.

It should not because all this code is gated by a feature. Was it in private?

I get the error running cargo ci lint in public (Error: command ["cargo", "clippy", "--all", "--tests", "--benches", "--", "-D", "warnings"] exited with code 101)

@jsdt jsdt added this pull request to the merge queue Jul 9, 2026
Merged via the queue into master with commit 5d2e86e Jul 9, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants