Conversation
bfops
marked this pull request as ready for review
September 26, 2026 12:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add cache-warming command under
cargo ci. Generally intended to be used by CI infrastructure, not people.I only skimmed the main file
tools/ci/commands/cache-warm/src/main.rsfor general structure. The CI performance was unchanged by moving things here, which makes me feel like the contents are probably correct.API and ABI breaking changes
None
Rollback safety impact
n/a
Expected complexity level and risk
Testing
Validated the new
cargo ci other-workflows cache-warmcommand against the previous shell-based warmer by deploying each image to the staging runner and rerunning the same CI workflow at the same merge commit.The sccache hit/miss counters were unchanged for every Linux staging job, and the Cargo target-directory cache produced equivalent freshness and build timings. All 11 non-skipped staging jobs passed.