Repository navigation
Validate endpoints before creating them - #104
Merged
Dany9966 merged 3 commits intoOct 28, 2026
Merged
Conversation
mihaelabalutoiu
force-pushed
the
fix-endpoint-validate-and-save
branch
from
October 1, 2026 09:31
6f45df6 to
cd0e42a
Compare
mihaelabalutoiu
marked this pull request as draft
October 12, 2026 09:35
Add `validate_connection_info`, which uses the `/endpoints/actions` validation action and takes the `platform` and `connection info` instead of an endpoint ID, and use it to validate before creating the `endpoint`, so invalid endpoints are no longer saved. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
fix-endpoint-validate-and-save
branch
from
October 12, 2026 09:45
0f7dbe8 to
69305e3
Compare
Add `endpoint validate connection info`, which validates the given platform and connection info without creating an endpoint. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
marked this pull request as ready for review
October 13, 2026 10:28
Dany9966
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
coriolis endpoint createcreated the endpoint first and validated it afterwards, so endpoints with invalidconnection_infowere saved even when the command reported a validation failure.This PR implements the following:
validate_connection_info, which uses the new/endpoints/actionsvalidation action and takes theplatformandconnection_infoinstead of an endpoint ID, and use it to validate before creating the endpoint, so invalid endpoints are no longer saved;validate endpoint connection info:endpoint validate connection info, which validates the givenplatformandconnection infowithout creating an endpoint;