Include specversion in GetPopulatedAttributes - #374
Open
authuir wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yu Zhou <zhouyu@microsoft.com>
Contributor
|
As it stands, this is a breaking change - the method is explicitly documented not to include the version attribute. The version attribute is "special" in various other ways - for example, it's read-only, and you can't access it via the indexer. If you really, really think there ought to be a way of obtaining all the attributes including the version (which is frankly easy enough to do at the caller side where necessary) we could introduce a new overload: public IEnumerable<KeyValuePair<CloudEventAttribute, object>> GetPopulatedAttributes(bool includeSpecVersionAttribute)The existing method could just return Personally I'm not really convinced it's worth doing this, but that would at least be much better than a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specversionand its canonical value inCloudEvent.GetPopulatedAttributes()This aligns attribute enumeration with the Java SDK, where
getAttributeNames()includes the populatedspecversioncontext attribute.Fixes #373
Testing
git diff --checkThe focused
CloudEventTestrun could not start locally because NuGet restore repeatedly timed out connecting toapi.nuget.org(SSL transport error: socket not connected).