Repository navigation
docs: return the transport promise from custom emitter examples - #651
Merged
duglin merged 1 commit intoOct 13, 2026
Merged
Conversation
kahirokunn
marked this pull request as ready for review
August 17, 2026 14:17
Contributor
Author
|
Hi ✋ would you mind taking a look when you have a chance? Thank you 🙏 |
Contributor
|
This pull request is stale because it has been open 30 days with no activity. |
Contributor
Author
|
keep |
shiva
approved these changes
Oct 13, 2026
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
docs-return-transport-promise
branch
from
October 13, 2026 04:47
7f0e6b8 to
21c3cf6
Compare
Contributor
|
per @shiva merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Return the Axios promise in the custom emitter examples.
Description
Returning the promise lets callers wait for Axios with
await emit(event).