Retain async context frames across scopes - #7096
Open
guybedford wants to merge 1 commit into
Open
Conversation
jasnell
approved these changes
Aug 22, 2026
Contributor
|
@guybedford Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This retains the previous async context frame while a scope temporarily replaces it.
AsyncContextFrame::Scopepreviously saved the prior frame as a borrowed reference. Replacing V8's continuation-preserved embedder data could make that frame unreachable, allowing GC to collect it before the scope restored it.The saved frame is now an owning
Ref. A regression test forces GC inside a nested scope and verifies the prior frame survives and is restored.Tested with the default and all-autogates async-context test variants.
PR made with AI under my review