Skip to content

fix: fixes Request body being released too early - #216

Merged
dom96 merged 1 commit into
mainfrom
dominik/request-body-proxy
Aug 24, 2026
Merged

fix: fixes Request body being released too early#216
dom96 merged 1 commit into
mainfrom
dominik/request-body-proxy

Conversation

@dom96

@dom96 dom96 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

It looks like we need to use create_proxy here to ensure the body isn't freed too early.

Test Plan

cd packages/runtime-sdk
uv run pytest 'tests/test_fastapi.py::TestPLATFORM_IO::test_upload_spills_binary_file_to_virtual_disk[3.13]' -v
uv run pytest 'tests/test_in_workerd.py::test_in_workerd[sdk-3.13]' -v

@dom96
dom96 requested a review from ryanking13 August 18, 2026 16:11
@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

ProviderModelNotFoundError

github run

@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

@dom96 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@ryanking13 ryanking13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread packages/runtime-sdk/src/workers/request.py Outdated
@dom96
dom96 force-pushed the dominik/request-body-proxy branch 3 times, most recently from da39196 to 2d81354 Compare August 21, 2026 15:10
@dom96
dom96 force-pushed the dominik/request-body-proxy branch from 2d81354 to 443c906 Compare August 21, 2026 15:10
@dom96
dom96 merged commit 84a20ac into main Aug 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants