Enforce lifecycle_type on apps, droplets, and builds - #5402
Open
WeiQuan0605 wants to merge 1 commit into
Open
Conversation
WeiQuan0605
force-pushed
the
make-lifecycle-type-non-nullable
branch
from
August 27, 2026 11:34
d59558f to
12637e5
Compare
WeiQuan0605
force-pushed
the
make-lifecycle-type-non-nullable
branch
from
August 27, 2026 12:32
12637e5 to
df8f659
Compare
WeiQuan0605
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5067
A short explanation of the proposed change:
Backfills NULL lifecycle_type values via a migration, enforces NOT NULL
constraint, removes fallback logic from models, optimizes AppListFetcher
(subqueries → simple WHERE clause), and optimizes ProcessPresenter eager
loading.
An explanation of the use cases your change solves
Allows lifecycle_type to be determined directly from the column without
joining lifecycle data tables, reducing N+1 queries and simplifying code.
Enables efficient filtering via GET /v3/apps?lifecycle_type=...
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests