Reduce migration spec runtime - #5419
Draft
johha wants to merge 1 commit into
Draft
Conversation
johha
force-pushed
the
next-test-optimzation
branch
8 times, most recently
from
September 7, 2026 09:55
d20c2bd to
144fc48
Compare
johha
changed the title
johha
force-pushed
the
next-test-optimzation
branch
from
September 7, 2026 14:26
e5ff76b to
f80cc60
Compare
Moves all migration specs off spec_helper (~11.6s load) onto the lightweight migration_spec_helper (~0.4s load), saving ~33s wall clock per CI run. Also consolidates multi-example it blocks and removes CC model usage where the spec only needed raw DB access. Changes to migration_spec_helper: - Add require 'steno/steno', 'sequel/plugins/microsecond_timestamp_precision' - Add require 'support/matchers/have_queried_db_times' and 'and_record_arguments' - Add Config#get stub method to allow instance_double verification - Set Sequel.default_timezone = :utc (was implicit via spec_helper) Bigint shared contexts: replace no-op allow_any_instance_of(Config) stubs with allow(Config).to receive(:config).and_return(migration_config) so opt_out? correctly reflects skip_bigint_id_migration per test context. Two specs remain on spec_helper (ensure_migrations_are_current, streamline_annotation_key_prefix) due to TestConfig/Rake and MetadataHelpers deps.
johha
force-pushed
the
next-test-optimzation
branch
from
September 7, 2026 14:28
f80cc60 to
faa6c77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests