Adding upload statistics and alerts for both app binary uploads towards the CF API and OS uploads #1885
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package org.cloudfoundry.multiapps.controller.persistence.monitoring; | ||
|
|
||
| import jakarta.inject.Named; | ||
|
|
||
| import java.util.concurrent.atomic.AtomicLong; | ||
| import java.util.concurrent.atomic.LongAdder; | ||
|
|
||
| @Named | ||
| public class UploadDurationTracker { | ||
|
|
||
| private final UploadPathStatistics appBinaryStatistics = new UploadPathStatistics(); | ||
|
|
||
| private final UploadPathStatistics objectStoreStatistics = new UploadPathStatistics(); | ||
|
|
||
| public void recordAppBinaryUpload(long durationMillis, boolean timedOut) { | ||
| appBinaryStatistics.record(durationMillis, timedOut); | ||
| } | ||
|
|
||
| public void recordObjectStoreUpload(long durationMillis, boolean timedOut) { | ||
| objectStoreStatistics.record(durationMillis, timedOut); | ||
| } | ||
|
|
||
| public void recordAppBinaryUploadRejection() { | ||
| appBinaryStatistics.recordRejection(); | ||
| } | ||
|
|
||
| public UploadPathStatistics getAppBinaryStatistics() { | ||
| return this.appBinaryStatistics; | ||
| } | ||
|
|
||
| public UploadPathStatistics getObjectStoreStatistics() { | ||
| return this.objectStoreStatistics; | ||
| } | ||
|
|
||
| public static final class UploadPathStatistics { | ||
|
|
||
| private final LongAdder total = new LongAdder(); | ||
|
|
||
| private final LongAdder timeouts = new LongAdder(); | ||
|
|
||
| private final LongAdder sumDuration = new LongAdder(); | ||
|
|
||
| private final LongAdder rejections = new LongAdder(); | ||
|
|
||
| private final AtomicLong rejectionsInWindow = new AtomicLong(0); | ||
|
|
||
| private final AtomicLong maxDuration = new AtomicLong(0); | ||
|
|
||
| private final AtomicLong timeoutsInWindow = new AtomicLong(0); | ||
|
|
||
| public void record(long durationMillis, boolean timedOut) { | ||
|
Check warning on line 51 in multiapps-controller-persistence/src/main/java/org/cloudfoundry/multiapps/controller/persistence/monitoring/UploadDurationTracker.java
|
||
| long duration = Math.max(0, durationMillis); | ||
| total.increment(); | ||
|
|
||
| if (timedOut) { | ||
| timeouts.increment(); | ||
| timeoutsInWindow.incrementAndGet(); | ||
| } | ||
|
|
||
| sumDuration.add(duration); | ||
| maxDuration.accumulateAndGet(duration, Math::max); | ||
| } | ||
|
|
||
| public void recordRejection() { | ||
| rejections.increment(); | ||
| rejectionsInWindow.incrementAndGet(); | ||
| } | ||
|
|
||
| public long totalCount() { | ||
| return total.sum(); | ||
| } | ||
|
|
||
| public long timeoutCount() { | ||
| return timeouts.sum(); | ||
| } | ||
|
|
||
| public long maxDurationMs() { | ||
| return maxDuration.getAndSet(0); | ||
|
IvanBorislavovDimitrov marked this conversation as resolved.
|
||
| } | ||
|
|
||
| public long sumDurationMs() { | ||
| return sumDuration.sum(); | ||
| } | ||
|
|
||
| public long timeoutsInWindow() { | ||
| return timeoutsInWindow.getAndSet(0); | ||
|
IvanBorislavovDimitrov marked this conversation as resolved.
|
||
| } | ||
|
|
||
| public long rejectionCount() { | ||
| return rejections.sum(); | ||
| } | ||
|
|
||
| public long rejectionsInWindow() { | ||
| return rejectionsInWindow.getAndSet(0); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package org.cloudfoundry.multiapps.controller.persistence.monitoring; | ||
|
|
||
| import com.google.cloud.storage.StorageException; | ||
| import io.netty.handler.timeout.ReadTimeoutException; | ||
|
|
||
| import java.net.SocketTimeoutException; | ||
| import java.util.concurrent.TimeoutException; | ||
|
|
||
| public class UploadTimeoutMatcher { | ||
|
|
||
| private UploadTimeoutMatcher() { | ||
|
|
||
| } | ||
|
|
||
| public static boolean isUploadTimeoutException(Throwable throwable) { | ||
| if (throwable == null) { | ||
| return false; | ||
| } | ||
|
|
||
| Throwable cause = throwable.getCause(); | ||
| while (cause != null) { | ||
| if (cause instanceof SocketTimeoutException || cause instanceof TimeoutException || cause instanceof ReadTimeoutException || ( | ||
| cause instanceof StorageException | ||
|
Check warning on line 23 in multiapps-controller-persistence/src/main/java/org/cloudfoundry/multiapps/controller/persistence/monitoring/UploadTimeoutMatcher.java
|
||
| && ((StorageException) cause).getCode() == 504)) { | ||
| return true; | ||
| } | ||
| cause = cause.getCause(); | ||
| } | ||
| return false; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.