Remove inheritVariables for processBatches call activities - #1893
Merged
Conversation
stiv03
marked this pull request as draft
August 7, 2026 12:57
stiv03
force-pushed
the
feature/remove-inherit-variables-processBatches
branch
2 times, most recently
from
August 11, 2026 06:56
16ec113 to
527dfef
Compare
stiv03
marked this pull request as ready for review
August 12, 2026 05:41
| </extensionElements> | ||
| </sequenceFlow> | ||
| <callActivity id="processBatchesSequentially" name="Process Resource Batches Sequentially" flowable:async="true" calledElement="processBatches" flowable:calledElementType="key" flowable:inheritVariables="true" flowable:completeAsync="true" flowable:fallbackToDefaultTenant="false"> | ||
| <callActivity id="processBatchesSequentially" name="Process Resource Batches Sequentially" flowable:async="true" calledElement="processBatches" flowable:calledElementType="key" flowable:completeAsync="true" flowable:fallbackToDefaultTenant="false"> |
Contributor
There was a problem hiding this comment.
Variable externalLoggingServiceConfigurations seems to be missing for the new cloud logging feature. Maybe needed in all diagrams
Contributor
|
Add LMCROSSITXSADEPLOY-3029 in commit as well |
Replace flowable:inheritVariables="true" on the processBatches call activities in rollback-mta, xs2-deploy and xs2-bg-deploy with an explicit flowable:in variable list, so only the variables the subprocess actually needs are passed instead of the whole parent variable map. The required set was derived from: - the processBatches step (ExtractBatchedServicesWithResolvedDynamicParametersStep) and its SyncFlowableStep base (correlationId, isSecurityEnabled, stepPhase), - the variables it forwards to createOrUpdateServicesSubProcess (already an explicit flowable:in list), minus variables produced inside processBatches itself: servicesToCreate (written, never read) and serviceToProcess (the child multi-instance element variable). dynamicResolvableParameters is kept because the step reads it before overwriting it. batchToProcess remains the caller's multi-instance element variable and is injected per iteration. Verified: FlowableEngineTest and ExtractBatchedServicesWithResolvedDynamicParametersStep tests pass.
Add externalLoggingServiceConfigurations to the processBatches flowable:in list in all three diagrams (xs2-deploy, xs2-bg-deploy, rollback-mta). The createOrUpdateServices child call activity forwards this variable and every step reads it via ProcessStepHelper for cloud logging export, so it must be passed into the processBatches subprocess now that inheritance is removed. Addresses review comment on PR #1893.
stiv03
force-pushed
the
feature/remove-inherit-variables-processBatches
branch
from
August 13, 2026 09:42
527dfef to
4bb5beb
Compare
|
Yavor16
requested changes
Aug 13, 2026
Yavor16
left a comment
Yavor16
left a comment
Contributor
There was a problem hiding this comment.
Can you check if the following variables must be added:
isServiceBindingKeyOperationInProgress
waitBindServiceTimeout
wasServiceBindingKeyOperationAlreadyDone
Yavor16
approved these changes
Aug 13, 2026
IvanBorislavovDimitrov
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-3029
Replace flowable:inheritVariables="true" on the processBatches call activities in rollback-mta, xs2-deploy and xs2-bg-deploy with an explicit flowable:in variable list, so only the variables the subprocess actually needs are passed instead of the whole parent variable map.
The required set was derived from: