Repository navigation
Conversation
A caller-supplied fetch_format (or its format alias) now replaces the default f_auto:video, with a matching MIME type. An empty source type delivers the asset as-is, without f_auto:video or an extension. VIDEO-21243
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: VIDEO-21243
Why
The player adds
f_auto:videoto everyautosource, and integrators had no way to opt out. A caller's ownfetch_formatwas chained in front of the default (f_mp4/f_auto:video/...) rather than replacing it, andformatinside a transformation was silently dropped.What changed
fetch_formatreplaces the defaultf_auto:video, and the source MIME type follows it.formatinside a transformation is an alias offetch_format. If both are set,fetch_formatwins.sourceTypes: ['']delivers the asset as-is, with nof_auto:videoand no extension. A bare URL resolves and serves the original file.getTransformationValuetosrc/utils/cloudinary.js.isKeyInTransformationnow uses it and behaves the same.f_auto:video/sea_turtletransformation: { fetch_format: 'mp4' }f_mp4/f_auto:video/sea_turtle,video/autof_mp4/sea_turtle,video/mp4transformation: { format: 'mp4' }f_auto:video/sea_turtle,video/autof_mp4/sea_turtle,video/mp4transformation: { fetch_format: 'auto' }f_auto/f_auto:video/sea_turtlesourceTypes: ['']sea_turtle.(broken),video/sea_turtle,video/autoThe default output is byte-identical. Explicit
sourceTypes(mp4,hls, ...) are unaffected.Not in this PR
raw_transformation: 'f_mp4'still getsf_auto:videoadded.Testing
test/unit/videoSource.test.jscover callerfetch_format/formatandsourceTypes: [''].npm run test:unitpasses (141 tests).