feat: support S3 addressing style across Barman commands - #290
Draft
davidchandra95 wants to merge 1 commit into
Draft
feat: support S3 addressing style across Barman commands#290davidchandra95 wants to merge 1 commit into
davidchandra95 wants to merge 1 commit into
Conversation
Signed-off-by: david <slowtyper@davids-MacBook-Pro-2.local>
davidchandra95
force-pushed
the
feat/s3-addressing-style
branch
from
August 10, 2026 07:25
275c78d to
773f2e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an ObjectStore-level
s3AddressingStylesetting forauto,virtual, orpath. The common command builder applies it to every Barman Cloud command and overrides older command-specific addressing arguments.Root cause
The existing
additionalCommandArgssettings only reached base-backup and WAL commands. Catalog, retention, and recovery commands used the shared builder without an addressing option, so S3 services that reject path-style URLs failed after a backup completed.Validation
go test ./...Staging use
A separate draft plugin and BBGE deployment change will use this source until an upstream release is available.