Repository navigation
Conversation
After the replica cluster is promoted, the operator recreates its standby to apply configuration changes that need a restart. The backup taken right after the promotion has no target, so it runs on the standby when one is ready, and fails when the operator deletes that pod during the backup. This made the switchover specs flaky in CI. Target the primary, as the source cluster backup already does. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
NiccoloFei
force-pushed
the
dev/replica-backup-target
branch
from
October 23, 2026 13:46
eea9a3f to
e30e244
Compare
Contributor
|
A test failure reference is https://github.com/cloudnative-pg/plugin-barman-cloud/actions/runs/39233610175/job/117997254725 |
NiccoloFei
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the replica cluster is promoted, the operator recreates its standby to apply configuration changes that need a restart. The backup taken right after the promotion has no target, so it runs on the standby when one is ready, and fails when the operator deletes that pod during the backup. This made the switchover specs flaky in CI, for example on #993.
Target the primary, as the source cluster backup already does.
Verified on kind by deleting the standby while the backup runs: without the change the backup ends
failed, with it the spec passes.