Repository navigation
Accept documented empty HTTP 200 login success - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept the documented successful login response: HTTP 200 with an exactly empty body. Only
_login_sessionskips JSON decoding for that exact case. Other statuses, nonempty responses, ordinary API decoding, cookie/CSRF checks, session ownership and MFA protections remain unchanged.Verification
e8b5c359efbc9f9481a1997d724227d79de25feb2ab60d45a1e08f168516f54a.e653ee7e8c233a697903aed2f114a753574c1b98; reviewed tree4ffe5d9af597825270859c36db47ebb54f415ef4.No live authentication, account/configuration/credential changes, OTP enrollment, releases or deployments. Synthetic transport does not qualify live server MFA/session behavior.