Repository navigation
refactor: reuse duplicate checks for End User members - #1785
Conversation
Preserve source-ID presence checks, unconditional seen-value tracking, owned-asset diagnostics and validation order using the merged duplicate-only helper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Maintainer-delegated P3 queue disposition: exact head 565cef6 is the explicitly approved issue1774 follow-up after merged PR1767. Reviewed both helper calls: existing source-ID presence checks, unconditional seen-value recording, paths/messages and ordering are preserved. Local focused, full required coverage, all six lint gates and build pass. Fresh required checks, CodeQL, DCO and end-to-end tests pass; the additional browser-coverage job is still running. In accordance with the maintainer instruction to queue ready work independently, submitting this exact head through the normal protected queue without waiting for unrelated PRs. Agent inspection is not independent human approval; no policy or protection bypass. |
Summary
Reuse the duplicate-only helper merged by #1767 for the two
remaining checks in
validate-enduser-members.mjs.value exactly as before; do not introduce missing-ID helper semantics.
check or a second helper.
The prerequisite is merged; this is the dependent follow-up, not a competing
implementation. Only the validator changes. All 15 existing focused member
and helper cases, the full required coverage gate, all six lint gates and
production build pass.
Maintainer authorization
The maintainer explicitly approved this bounded issue1774 follow-up after
PR1767, and delegated its exact-head protected merge once fresh required
checks pass. Agent inspection is not independent human approval; no
protection, validation, mutation or advisory policy is changed.
Closes #1774.