Repository navigation
fix(launch): refresh post-cutover metrics baseline - #1842
Conversation
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
34c3258
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @mrbobbytables, head
Hive did not add the |
34c3258 to
30b17b0
Compare
There was a problem hiding this comment.
Read the regenerated baseline against the collector and both test files at head 30b17b0.
scripts/collect-launch-metrics.mjs:66-72anddata/launch-metrics.jsonagree on the new checkpoint (label,targetDate: 2026-10-22, note), anddata/launch-metrics.jsoncarries one sharedcollectedAtacross all five signals, matching the invarianttests/collect-launch-metrics.test.mjspins ("capturedAt is a single ISO timestamp shared by every signal").scripts/validate-launch-metrics.mjs:49-62validates checkpoint shape generically (label present, parseable date), so the committed file passes without validator changes.- Grepped the PR head for
W-6and2026-09-28: no stale references remain outside the unrelateddata/metrics.jsontimestamps. - Forks baseline
2 → 3is consistent with a fresh capture, and the mocked-payload assertion intests/collect-launch-metrics.test.mjs:121(baseline 6 from fixture routes) is untouched, so the fixture/committed-data split holds.
The diff does exactly what the body claims. Looks correct to me — ready for a maintainer's sign-off.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
The 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.88 |
Refresh the generated launch metrics after the DNS cutover and mark the capture as the post-cutover baseline. Anchor the comparison to capturedAt and update the roadmap. Hive-Run: #1830 Hive-Plan: Launch metrics baseline refresh Hive-Spec: launch-success-metrics#post-cutover-baseline Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
30b17b0 to
9df7852
Compare
There was a problem hiding this comment.
Verified, looks correct to me.
- All four moving parts stay consistent:
data/launch-metrics.json, the constants inscripts/collect-launch-metrics.mjs:66-71, the checkpoint test intests/collect-launch-metrics.test.mjs, and the validator fixture intests/validate-launch-metrics.test.mjs:21-22all carry the new label/date together. - After this diff, no stale
W-6or2026-09-28checkpoint reference remains in the tree — I grepped*.mjs/*.md/*.json; the only surviving2026-09-28strings are unrelateddata/metrics.jsoncollection timestamps. - The refresh follows the repo's generated/never-hand-edited data pattern, and
generatedAt/capturedAt/per-signalcollectedAtshare one timestamp as the existing test requires.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Summary
Refresh the generated success-metrics baseline after the 2026-10-22 DNS cutover, update its checkpoint metadata and collector, and clarify that
capturedAtanchors the 90-day comparison.Closes #1830
Verification
npm run collect:launch-metricsnpm run validate:launch-metricsnpm run buildtests/enduser-collector.test.mjsandtests/helpers-spawn-fallbacks.test.mjs); 3,529 of 3,532 tests passed.— hive: backend=copilot model=claude-fable-5.1
🐝 Hive Agent:
contributor| SHA:465bf51