Skip to content

fix(launch): refresh post-cutover metrics baseline - #1842

Merged
mrbobbytables merged 1 commit into
mainfrom
hive/1830-launch-metrics-post-cutover
Oct 23, 2026
Merged

mrbobbytables merged 1 commit into
mainfrom
hive/1830-launch-metrics-post-cutover

Conversation

@mrbobbytables

Copy link
Copy Markdown
Member

Summary

Refresh the generated success-metrics baseline after the 2026-10-22 DNS cutover, update its checkpoint metadata and collector, and clarify that capturedAt anchors the 90-day comparison.

Closes #1830

Verification

  • npm run collect:launch-metrics
  • npm run validate:launch-metrics
  • Focused launch-metrics tests (42 passed)
  • npm run build
  • Formatting, spelling, changed-file lint, and unused-code checks passed
  • The full coverage gate had 3 unrelated test failures (tests/enduser-collector.test.mjs and tests/helpers-spawn-fallbacks.test.mjs); 3,529 of 3,532 tests passed.

— hive: backend=copilot model=claude-fable-5.1


🐝 Hive Agent: contributor | SHA: 465bf51

@netlify

netlify Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endusers ready!

Name Link
🔨 Latest commit 9df7852
🔍 Latest deploy log https://app.netlify.com/projects/endusers/deploys/6adba6c5e2821682ac602805
😎 Deploy Preview https://deploy-preview-1842--endusers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mrbobbytables
mrbobbytables added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 23, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
34c3258

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @mrbobbytables, head 34c325862eb8) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • SECURITY.md
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • scripts/audit-gate.mjs
  • security_policy_edit — edits security policy, scanner config, rulesets or hooks (Edits SECURITY.md, dependabot/CodeQL config, rulesets or git hooks)
    • SECURITY.md

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@mrbobbytables
mrbobbytables force-pushed the hive/1830-launch-metrics-post-cutover branch from 34c3258 to 30b17b0 Compare October 23, 2026 17:44

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the regenerated baseline against the collector and both test files at head 30b17b0.

  • scripts/collect-launch-metrics.mjs:66-72 and data/launch-metrics.json agree on the new checkpoint (label, targetDate: 2026-10-22, note), and data/launch-metrics.json carries one shared collectedAt across all five signals, matching the invariant tests/collect-launch-metrics.test.mjs pins ("capturedAt is a single ISO timestamp shared by every signal").
  • scripts/validate-launch-metrics.mjs:49-62 validates checkpoint shape generically (label present, parseable date), so the committed file passes without validator changes.
  • Grepped the PR head for W-6 and 2026-09-28: no stale references remain outside the unrelated data/metrics.json timestamps.
  • Forks baseline 2 → 3 is consistent with a fresh capture, and the mocked-payload assertion in tests/collect-launch-metrics.test.mjs:121 (baseline 6 from fixture routes) is untouched, so the fixture/committed-data split holds.

The diff does exactly what the body claims. Looks correct to me — ready for a maintainer's sign-off.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The End-to-end coverage failure on this PR is the shared incident tracked in #1809, not a problem with this diff: the same 6 accepted region(s) in tests/e2e/fixtures/accepted-regions.json are stale error fails on the default branch (run 39995846213 @ 1d2374f) and on sibling PR #1845. Deferred until the incident closes — the held fix PR #1810 removes the stale fixture entries. No action needed on this PR beyond a re-run once #1810 merges.


🐝 Hive Agent: scanner | Instance: hosted-available-lke648397-260827-5n31 | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.88

Refresh the generated launch metrics after the DNS cutover and mark the capture as the post-cutover baseline. Anchor the comparison to capturedAt and update the roadmap.

Hive-Run: #1830

Hive-Plan: Launch metrics baseline refresh

Hive-Spec: launch-success-metrics#post-cutover-baseline

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@mrbobbytables
mrbobbytables force-pushed the hive/1830-launch-metrics-post-cutover branch from 30b17b0 to 9df7852 Compare October 23, 2026 18:26

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, looks correct to me.

  • All four moving parts stay consistent: data/launch-metrics.json, the constants in scripts/collect-launch-metrics.mjs:66-71, the checkpoint test in tests/collect-launch-metrics.test.mjs, and the validator fixture in tests/validate-launch-metrics.test.mjs:21-22 all carry the new label/date together.
  • After this diff, no stale W-6 or 2026-09-28 checkpoint reference remains in the tree — I grepped *.mjs/*.md/*.json; the only surviving 2026-09-28 strings are unrelated data/metrics.json collection timestamps.
  • The refresh follows the repo's generated/never-hand-edited data pattern, and generatedAt/capturedAt/per-signal collectedAt share one timestamp as the existing test requires.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@mrbobbytables
mrbobbytables added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 79a3492 Oct 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[strategist] Launch success-metrics baseline is still the pre-cutover (2026-10-02) snapshot, 20 days before the actual 2026-10-22 launch

1 participant