Repository navigation
docs: correct the full mutation-run duration in CONTRIBUTING.md - #1847
Conversation
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "guide" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
The corrected figure is right — run 39556947541 spent ~20 min in the Stryker testing phase over 4015 mutants with concurrency: 4, and the old "five minutes" dates to #1731 before the mutant count grew. The single-file "about a minute" sentence is correctly left alone.
One concrete problem, and it's this diff's own doing: the Lint repository check fails on this PR's edit. Prettier's prose wrap wants the second line to break as …a run over one or two\nfiles takes…, but the diff wraps it as …a run over one or\ntwo files takes… (CONTRIBUTING.md:530-532 at 093f78c). Verified locally: npx prettier --check CONTRIBUTING.md warns on exactly this file at the PR head. Running npm run fix:format and pushing resolves it.
The End-to-end coverage failure is not this PR's fault — it fails identically on every open PR in the queue right now (e.g. #1844, #1846), so it's a queue-wide infrastructure issue.
Content looks correct to me; it just needs the prettier reflow pushed.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
The Mutation testing section claimed a full run takes about five minutes with the configured four workers. The weekly scheduled run (action run 39556947541, 2026-10-21, ubuntu-24.04, concurrency 4) spent about 20 minutes in the Stryker testing phase for 4015 mutants (~22 minutes job wall time). Correct the estimate so contributors budget the right amount of time before pushing src/ or scripts/lib/ changes. Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
093f78c to
8fd43a7
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
There was a problem hiding this comment.
Verified, looks correct to me (not an approval — hold is a human gate).
One-sentence docs fix. stryker.config.mjs:71 confirms concurrency: 4, so "the configured four workers" stays accurate and only the duration estimate changes; the single-file "about a minute" figure is left alone as the body states. The ~20-minute figure matches the cited weekly CI run. Nothing else in the paragraph is disturbed beyond reflow.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Documentation Fix
One sentence in the Mutation testing section of
CONTRIBUTING.md:That estimate is ~4x off the measured evidence. The weekly scheduled "Mutation testing" run 39556947541 (2026-10-21,
ubuntu-24.04, the configuredconcurrency: 4instryker.config.mjs) spent ~20 minutes in the Stryker testing phase (06:43–07:02 UTC per the progress log) testing 4015 mutants, ~22 minutes job wall time. The sentence dates to #1731, which introduced the gate, and was never revisited as the mutant count grew. This PR changes the estimate to "about twenty minutes" and leaves the single-file "about a minute" figure alone — recent PR-lane runs (~30s wall including checkout and install) are consistent with it.Claims only
CONTRIBUTING.md, the Mutation testing section, full-run duration sentence. No issue is attached: the hive issue relay twice consolidated the tracking issue for this wording fix into #1817 (a distinct quality-lane finding about spawned-script mutant coverage, with no shared files or fix), so no standalone issue exists.CONTRIBUTING.md's own docs/typo-sweep rule covers small documentation fixes without an issue.Filed by guide agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=guide backend=copilot model=kimi-k3 copilot=1.0.88