Repository navigation
test(sweep): pin that a second delayed sweep leaves the first run's requested reviewers alone - #559
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…equested reviewers alone The delayed-blunderbuss bundle suite modelled a pull that already had reviewers only as a static fixture. This drives dist/index.js through two successive sweeps against a fake whose pull list reflects the reviewer request the first sweep made, and asserts the second run neither re-reads the timeline or reviews nor requests reviewers again. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
Contributor
|
Please add a kind label with |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds one bundle scenario to
__tests__/bundle/blunderbussDelay.test.ts(dist/index.js delayed blunderbuss): the sweep runs twice against a fake GitHub whoseGET /pullslist reflects everyPOST …/requested_reviewersit has accepted so far. The second run must logsweep: #1 already has requested reviewers, make no further timeline or review reads, and leave exactly one reviewer request on record.This is the Successive sweeps box of #554 ("run again against state updated by the first run … assert no duplicate or unwanted reviewer requests"). The manual-assignment half of that box is already pinned by the existing
a manual reviewer/a manual teamcases in the same file.Cluster claimed:
src/cronJobs/sweep.tsrequestReviewersIfDuerequested-reviewers guard, bundle level only. Disjoint from #555 (pagination), #557 (tide), #558 (__tests__/cronJobTest/sweep.test.tsdue-window bounds);git merge-treeagainst #555 and #558 shows no conflict.Verification
npx vitest run __tests__/bundle/blunderbussDelay.test.ts→ 18/18 ataa71e9anpx eslint __tests__/bundle/blunderbussDelay.test.tscleanrequested()andreviewReads()staying at length 1 after the second run; removing the guard would make both 2.Related Issue
Refs #554 — umbrella tracker; this closes only its successive-sweeps box. Remaining boxes (OWNERS page-two failure, outage recovery, CI enforcement, release) stay open, and the OWNERS page-two failure scenario waits on #555's
fakeGithubheader support landing.Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 requested_by=@mrbobbytables