Skip to content

test(config): pin normalizeBlunderbuss' non-Error parseDuration arm and v8-ignore it for the bundle #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hivecommons-hive wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(config): pin normalizeBlunderbuss' non-Error parseDuration arm and v8-ignore it for the bundle #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions __tests__/utils/configBlunderbussDelay.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { describe, expect, it, vi } from 'vitest'

import { parseProwConfig } from '../../src/utils/config'
import * as duration from '../../src/utils/duration'

vi.mock('../../src/utils/duration', { spy: true })

describe('normalizeBlunderbuss', () => {
it('stringifies a non-Error thrown while parsing blunderbuss.delay', () => {
vi.mocked(duration.parseDuration).mockImplementationOnce(() => {
throw 'clock skew' // eslint-disable-line no-throw-literal
})

expect(() => parseProwConfig('x', 'blunderbuss:\n delay: 1h\n')).toThrow('x: clock skew')
})
})
3 changes: 2 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41210,7 +41210,8 @@ function normalizeBlunderbuss(source, raw) {
ms = parseDuration(raw.delay, 'blunderbuss.delay');
}
catch (e) {
throw new Error(`${source}: ${e instanceof Error ? e.message : e}`);
// parseDuration throws only Error
throw new Error(`${source}: ${e instanceof Error ? e.message : /* v8 ignore next -- non-Error arm unreachable from dist/index.js; configBlunderbussDelay.test.ts drives it */ e}`);
}
if (ms > maxBlunderbussDelayMs) {
throw new Error(`${source}: blunderbuss.delay must not be longer than 24h`);
Expand Down
3 changes: 2 additions & 1 deletion src/utils/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,8 @@ function normalizeBlunderbuss(source: string, raw: unknown): BlunderbussConfig {
ms = parseDuration(raw.delay, 'blunderbuss.delay')
}
catch (e) {
throw new Error(`${source}: ${e instanceof Error ? e.message : e}`)
// parseDuration throws only Error
throw new Error(`${source}: ${e instanceof Error ? e.message : /* v8 ignore next -- non-Error arm unreachable from dist/index.js; configBlunderbussDelay.test.ts drives it */ e}`)
}
if (ms > maxBlunderbussDelayMs) {
throw new Error(`${source}: blunderbuss.delay must not be longer than 24h`)
Expand Down
Loading