Repository navigation
test(sweep): pin the ignore_drafts=false arm of delayed reviewers (requestReviewersIfDue, sweep.ts:218) - #566
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…eep.ts:218) With blunderbuss.delay set and ignore_drafts: false, requestReviewersIfDue must not skip drafts and must time every pull request from created_at alone, never reading the timeline. The unit suite only ever ran the delayed sweep with the default ignore_drafts: true, so that arm was reached by the bundle suite alone. Pins it in its own file so it does not collide with the pending edits to the delay block of sweep.test.ts. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Test Improvement
Adds
__tests__/cronJobTest/sweepDelayIgnoreDrafts.test.ts, a unit test for theignore_draftsfalse arm ofrequestReviewersIfDueinsrc/cronJobs/sweep.ts(line 218). Withblunderbuss: { delay: 1h, ignore_drafts: false }it pins that a delayed sweep:issues/:number/timeline, even when that timeline would report aready_for_review5 minutes ago — the pull request is timed fromcreated_atalone;created_atgate at line 214 applies unchanged, and the draft stays a tide candidate.It lives in its own file, mirroring #561/#562/#565, so it does not touch the
sweep with blunderbuss.delayblock ofsweep.test.tsthat #558 edits.Evidence (main@e3119ad, local runs)
npm run test:coverage:coverage/lcov.infoBRDA:218,30,1,0. With this file, a sweep.ts-scoped coverage run of the new test recordsBRDA:218,30,1,2.npm run test:coverage:e2e:BRDA:218,30,1,1via__tests__/bundle/blunderbussDelay.test.ts("uses creation time and requests on a due draft when ignore_drafts is false") — so this was an e2e-only path, priority low.npm run lint -- __tests__/cronJobTest/sweepDelayIgnoreDrafts.test.tsclean;npx vitest run __tests__/cronJobTest/sweepDelayIgnoreDrafts.test.ts2 passed.Related Issue
Refs #560 — this lands the folded
sweep.ts:218variant only; the tracker's other folded arms remain with #561 (line 80), #562 (line 208), #563 (config.ts:618) and #565 (line 85).Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1