Conversation
|
I think it was @MicahGale who proposed this erroneous addition, so we'll let him review :) |
I proposed only |
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write |
There was a problem hiding this comment.
This allows the CI to write PR messages. Is it actually doing that? Also I am skeptical that contents: write is necessary.
There was a problem hiding this comment.
Oh is the contents: write for committing updates from Zotero?
| - name: Push changes # push the output folder to your repo | ||
| uses: ad-m/github-push-action@master | ||
| uses: ad-m/github-push-action@v1 |
There was a problem hiding this comment.
I try to avoid this one off third party actions. You can just use gh from the shell directly I think.
There was a problem hiding this comment.
I'll make updating this workflow a different PR and remove this change
|
|
||
| jobs: | ||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
How did this break things?
There was a problem hiding this comment.
"Invalid workflow file: .github/workflows/test_build.yml#L1
(Line: 8, Col: 5): Unexpected value 'contents', (Line: 8, Col: 5): There's not enough info to determine what you meant. Add one of these properties: cancel-timeout-minutes, container, continue-on-error, defaults, env, environment, outputs, runs-on, secrets, services, snapshot, steps, timeout-minutes, uses, with"
There was a problem hiding this comment.
Oh I see the issue. This was supposed by inside the job.
2 participants
I added these hastily in review, but there was already a permissions block in the correct place and this caused failure.