feat(api): persist RWEB best practices with catalog and result tables - #161
Merged
Merged
Conversation
Store best-practice definitions and per-analysis evaluation snapshots,
expose them via GET /ecoindexes/{id}/best-practices, and opt in with
include_best_practices on task creation.
Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid an explicit column equality onclause that ty types as bool. Co-authored-by: Cursor <cursoragent@cursor.com>
Branch coverage •
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiecoindexbestpractices) synced from YAML rules, and per-analysis results (apiecoindexbestpracticeresults) with threshold snapshotsinclude_best_practices, and exposeGET /{id}/best-practicesTest plan
include_best_practices=trueand verify catalog sync + result rowsGET /v1/ecoindexes/{id}/best-practicesand check payload / 204 when not collectedtest/components/ecoindex/database/test_repository_queries.pyMade with Cursor