Repository navigation
fix(build): remove redundant force-include for default_rules.yaml - #162
Merged
Merged
Conversation
The wheel force-include pointed to a monorepo path outside the sdist, which breaks uv's two-step build (sdist then wheel). Polylith already ships non-Python brick files, so default_rules.yaml is included without it. Co-authored-by: Cursor <cursoragent@cursor.com>
Branch coverage •
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[tool.hatch.build.targets.wheel.force-include]fordefault_rules.yamlfrom scraper, API, and CLI packagesuv buildbuilds a wheel from the sdist and hatchling cannot resolve the monorepo path../../components/ecoindex/best_practices/default_rules.yamldefault_rules.yamlremains packaged correctlyTest plan
task scraper:uv:buildtask api:uv:buildtask cli:uv:buildecoindex/best_practices/default_rules.yamlis present in built wheelsMade with Cursor