style: Fix RSpec structural offenses - #2742
Merged
Merged
Conversation
Fix RSpec/EmptyLineAfterHook offenses in: - spec/controllers/admin/member_search_controller_spec.rb - spec/models/workshop_invitation_spec.rb - spec/models/workshop_spec.rb Regenerate .rubocop_todo.yml.
Fix RSpec/EmptyLineAfterSubject offenses in: - spec/models/event_spec.rb - spec/models/meeting_spec.rb - spec/models/workshop_invitation_spec.rb - spec/models/workshop_spec.rb Regenerate .rubocop_todo.yml.
Fix RSpec/EmptyLineAfterFinalLet offenses in: - spec/lib/tasks/delete_member_rake_spec.rb - spec/models/sponsor_spec.rb Regenerate .rubocop_todo.yml.
Fix RSpec/ExpectInHook offenses by moving expectations out of before and after hooks into the relevant example bodies: - spec/controllers/admin/invitations_controller_spec.rb - spec/support/shared_examples/behaves_like_managing_workshop_attendance.rb Regenerate .rubocop_todo.yml.
Fix RSpec/HooksBeforeExamples offense in spec/support/shared_examples/behaves_like_managing_workshop_attendance.rb and regenerate .rubocop_todo.yml.
Fix RSpec/EmptyLineAfterExampleGroup offense in spec/features/admin/manage_sponsor_spec.rb and regenerate .rubocop_todo.yml.
Fix RSpec/NoExpectationExample offenses in spec/lib/services/flodesk_spec.rb by asserting the response of subscribe/unsubscribe, and regenerate .rubocop_todo.yml.
Remove the empty spec/models/address_spec.rb and regenerate .rubocop_todo.yml.
mroderick
marked this pull request as ready for review
July 28, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the RSpec structural cops.
Eight commits:
style: Fix RSpec/EmptyLineAfterHook offenses— 6 offenses in 3 filesstyle: Fix RSpec/EmptyLineAfterSubject offenses— 4 offenses in 4 filesstyle: Fix RSpec/EmptyLineAfterFinalLet offenses— 2 offenses in 2 filesstyle: Fix RSpec/ExpectInHook offenses— 2 offenses, manually fixed (moved expectations out of hooks)style: Fix RSpec/HooksBeforeExamples offense— 1 offensestyle: Fix RSpec/EmptyLineAfterExampleGroup offense— 1 offensestyle: Fix RSpec/NoExpectationExample offenses— 2 offenses, manually fixed (added response assertion)style: Fix RSpec/EmptyExampleGroup offense— removed empty spec fileEach commit removes the relevant exclusion from .rubocop_todo.yml and regenerates it.
bundle exec rubocopis green