style: Fix Capybara offenses - #2743
Merged
Merged
Conversation
Fix Capybara/RSpec/NegationMatcherAfterVisit in spec/features/admin/chapters_spec.rb and regenerate .rubocop_todo.yml.
Fix 6 offenses and regenerate .rubocop_todo.yml.
Fix 17 offenses and regenerate .rubocop_todo.yml.
Fix 21 offenses and regenerate .rubocop_todo.yml.
Fix 49 offenses and regenerate .rubocop_todo.yml.
Fix 339 offenses and regenerate .rubocop_todo.yml.
mroderick
marked this pull request as ready for review
July 28, 2026 07:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Capybara cops.
Seven commits:
style: Fix Capybara/RSpec/NegationMatcherAfterVisit offense— 1 offense, manual (wait with positive matcher first)style: Fix Capybara/RSpec/VisibilityMatcher offense— 1 offense, autocorrectedstyle: Fix Capybara/SpecificFinders offenses— 6 offenses, autocorrectedstyle: Fix Capybara/RSpec/CurrentPathExpectation offenses— 17 offenses, autocorrectedstyle: Fix Capybara/RSpec/HaveSelector offenses— 21 offenses, autocorrectedstyle: Fix Capybara/RSpec/NegationMatcher offenses— 49 offenses, autocorrectedstyle: Fix Capybara/RSpec/HaveContent offenses— 339 offenses, autocorrectedEach commit removes the relevant exclusion from .rubocop_todo.yml and regenerates it.
bundle exec rubocopis green