chore: fix 3 Lint RuboCop cops - #2750
Merged
Merged
Conversation
mroderick
marked this pull request as ready for review
July 28, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes 3 Lint cops via autocorrect, one commit per rule, then regenerates
.rubocop_todo.yml.Cops fixed
Lint/AmbiguousBlockAssociationLint/UnusedBlockArgumentLint/UselessAssignment25 offenses fixed. 22 files changed.
Remaining Lint cops (not autocorrectable)
Lint/AssignmentInCondition— 2 offenses. Uses safe-assignment-in-condition()pattern withAllowSafeAssignment: false. Needs manual refactor to avoid assignment in conditions.Lint/UselessTimes— 2 files remaining (event_spec.rb,workshop_spec.rb).1.times.map/1.times.collectpatterns don't autocorrect. Needs manual replacement with direct array literals.Todo dropped from 894 → 867 remaining.