chore(rubocop): fix RSpec/ cops - #2753
Merged
Merged
Conversation
RSpec/ImplicitSubject had 3 stale Exclude entries — the one-liner `is_expected` usage in those files already matches the allowed `single_line_only` style.
Name all test subjects to satisfy rubocop-rspec's NamedSubject cop. - Policy specs: subject(:policy) - Model specs: use the existing named subject aliases (contact, sponsor, group, workshop_invitation, workshop, workshop_sponsor) instead of the bare `subject` keyword
Replace bare `expect(page.all(...))` (no .to chain) with idiomatic `expect(page).to have_css(...)` for table row count assertions.
Rename indexed let(:member1)/let(:member2) to descriptive alice/bob.
Replace instance variables with let/let! in feature specs. - add_user_to_workshop_spec: @start_page → let(:start_page) - member_feedback_spec: @tutorial → let!(:tutorial)
Replace let! used only for setup with before blocks, or reference named let! that must be eager.
Merge duplicate examples and rename duplicate context descriptions. - Sponsors controller: merge two identical examples into one - Invitation route shared example: remove duplicate scenario with typo - Manage sponsor spec: disambiguate duplicate context descriptions
mroderick
force-pushed
the
fix/rubocop-rspec
branch
from
July 28, 2026 16:55
d967d79 to
8fbd44f
Compare
…bjectStub - LeakyConstantDeclaration: remove unused MAX_RETRIES constant - SpecFilePathFormat: add CustomTransform for OmniAuth→omniauth - MessageChain: replace receive_message_chain with allow + double - SubjectStub: move exclude from todo to .rubocop.yml
…ngth, MultipleMemoizedHelpers Increase thresholds to reduce noise in todo file while keeping meaningful enforcement: - MultipleExpectations: 2 → 8 - ExampleLength: 10 → 25 - MultipleMemoizedHelpers: add Max: 15
mroderick
force-pushed
the
fix/rubocop-rspec
branch
from
July 28, 2026 16:57
8fbd44f to
89bfd5d
Compare
mroderick
marked this pull request as ready for review
July 28, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix 12 RSpec/ cops from
.rubocop_todo.yml— 9 commits, one per rule.Changes
expect(page.all(...))withhave_cssmember1/member2toalice/bob@start_page/@tutorialwithletlet!tobeforeblocksreceive_message_chainRemaining (deferred)
Verification
bundle exec rubocoppasses (0 offenses)