Repository navigation
Assert the waiting-list promotion email on reject - #3001
Merged
mroderick merged 2 commits intoOct 9, 2026
Merged
Conversation
This was referenced Oct 9, 2026
The reject flow emails the promoted member via WorkshopPresenter#send_attending_email(invitation, true), and no spec asserted any of it (only the resulting invitation state). Pin it: the promoted member receives an attending confirmation, the body uses the promotion copy (only rendered when waiting_list is true; the plain accept copy differs), and exactly one email goes out. The admin-removal call site assertion is out of scope here; it can be added once the feat/post-close-rsvp-waitlist branch merges.
mroderick
force-pushed
the
test/waitlist-promotion-email
branch
from
October 9, 2026 06:56
7ca6aa0 to
5ac871b
Compare
mroderick
marked this pull request as ready for review
October 9, 2026 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every waiting-list promotion emails the promoted member via
WorkshopPresenter#send_attending_email(invitation, true), and no spec asserted any of it — only the resulting invitation state. This PR pins the email for the reject flow.One of five small PRs from the same pre-existing-gap audit. Heads are reviewed independently; if a sibling merges first expect a trivial rebase.
Detail
Three assertions, inside the existing "when someone are on waiting list" reject context:
waiting_listis true; the plain accept copy says something else.Repo specifics worth knowing for review. The test queue adapter is delayed_job;
delay_jobs = falseintest means
deliver_laterdelivers intoActionMailer::Base.deliveries. The invitation mailer ismultipart/mixed > multipart/alternative > text/html, so the root
body.decodedis empty — the specsread the nested html part via a small
html_bodyhelper.Review notes
feat/post-close-rsvp-waitlist, which introduces that call site.Sibling PRs: