Skip to content

fix: ensure submodule files are included with --recurse-submodules #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure submodule files are included with --recurse-submodules #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions codecov_cli/helpers/versioning_systems.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,25 @@ def list_relevant_files(
if dir_to_use is None:
raise ValueError("Can't determine root folder")

if recurse_submodules:
init_res = subprocess.run(
[
"git",
"-C",
str(dir_to_use),
"submodule",
"update",
"--init",
"--recursive",
],
capture_output=True,
)
if init_res.returncode != 0:
logger.warning(
"git submodule update --init --recursive failed; submodule files may be missing from the network. "
+ init_res.stderr.decode().strip()
)

cmd = ["git", "-C", str(dir_to_use), "ls-files", "-z"]
if recurse_submodules:
cmd.append("--recurse-submodules")
Expand Down
Loading