Skip to content

fix: prevent ValueError when slug is missing in upload #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent ValueError when slug is missing in upload #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions codecov_cli/services/upload/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

from codecov_cli.fallbacks import FallbackFieldEnum
from codecov_cli.helpers.ci_adapters.base import CIAdapterBase
from codecov_cli.helpers.encoder import slug_with_subgroups_is_invalid
from codecov_cli.helpers.request import log_warnings_and_errors_if_any
from codecov_cli.helpers.versioning_systems import VersioningSystemInterface
from codecov_cli.helpers.upload_type import ReportType
Expand Down Expand Up @@ -64,6 +65,11 @@ def do_upload_logic(
report_type: ReportType = ReportType.COVERAGE,
use_legacy_uploader: bool = False,
):
if not slug or slug_with_subgroups_is_invalid(slug):
raise click.ClickException(
"Slug is required but was not provided or is invalid. "
"Please provide it via the --slug option in the format 'owner/repo'."
)
plugin_config = {
"folders_to_ignore": files_search_exclude_folders,
"gcov_args": gcov_args,
Expand Down
Loading