Skip to content

fix: handle missing 'module'/'class' keys in custom plugin config #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle missing 'module'/'class' keys in custom plugin config #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions codecov_cli/plugins/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ def select_preparation_plugins(


def _load_plugin_from_yaml(plugin_dict: typing.Dict):
if not plugin_dict.get("module") or not plugin_dict.get("class"):
click.secho(
"Plugin config must include 'module' and 'class' keys",
err=True,
)
return NoopPlugin()
try:
module_obj = import_module(plugin_dict["module"])
class_obj = getattr(module_obj, plugin_dict["class"])
Expand Down
Loading