Skip to content

fix: propagate fail_on_error in upload-coverage command - #772

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/propagate-fail-on-error-upload-coverage
Open

fix: propagate fail_on_error in upload-coverage command#772
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/propagate-fail-on-error-upload-coverage

Conversation

@sentry

@sentry sentry Bot commented Aug 23, 2026

Copy link
Copy Markdown

The upload-coverage command, when handling report types other than COVERAGE (e.g., test_results), was incorrectly hardcoding fail_on_error=True for its internal create_commit and create_report invocations. This meant that even if the user did not specify --fail-on-error for the upload-coverage command, any failure during commit or report creation would lead to a non-zero exit code.

This change modifies codecov_cli/commands/upload_coverage.py to correctly pass the fail_on_error parameter provided to the upload-coverage command down to create_commit and create_report. This ensures consistent behavior where the CLI's exit code reflects the user's explicit --fail-on-error setting.

Fixes CLI-GM

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
723 1 722 1
View the full list of 1 ❄️ flaky test(s)
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 100.00% (Passed 0 times, Failed 1726 times)

Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants