fix: propagate fail_on_error in upload-coverage command - #772
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
upload-coveragecommand, when handling report types other thanCOVERAGE(e.g.,test_results), was incorrectly hardcodingfail_on_error=Truefor its internalcreate_commitandcreate_reportinvocations. This meant that even if the user did not specify--fail-on-errorfor theupload-coveragecommand, any failure during commit or report creation would lead to a non-zero exit code.This change modifies
codecov_cli/commands/upload_coverage.pyto correctly pass thefail_on_errorparameter provided to theupload-coveragecommand down tocreate_commitandcreate_report. This ensures consistent behavior where the CLI's exit code reflects the user's explicit--fail-on-errorsetting.Fixes CLI-GM
This PR was automatically generated by Sentry. You can adjust this setting at any time.